linxingyuan1102 commented on issue #459: Consider replacing TableOperations parameter in TableMetadataParser::read URL: https://github.com/apache/incubator-iceberg/issues/459#issuecomment-529578442 > I like the idea but I am curious how we plan to replace `ops$current` and other calls. @aokolnychyi Thanks for the comment. As per my inspection, `ops$current` is called when `Snapshot::addedFiles`/`Snapshot::deletedFiles` is called. Essentially, it is used to get a `specLookup` function, which is essentially a mapping from spec ID to partition spec. I think it should be okay to store such a mapping in `BaseSnapshot`, i.e., to replace the `TableOperations` field with `Map<Integer, PartitionSpec>` and `FileIO`. Also, from my understanding, it's more intuitive to not let a certain `TableMetadata`'s behavior depend on the table's (future) state (`ops$current`). What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
