rdblue commented on a change in pull request #486: Optimize StreamingDelete
URL: https://github.com/apache/incubator-iceberg/pull/486#discussion_r326353811
##########
File path: api/src/main/java/org/apache/iceberg/DeleteFiles.java
##########
@@ -51,10 +51,7 @@
* @param file a DataFile to remove from the table
* @return this for method chaining
*/
- default DeleteFiles deleteFile(DataFile file) {
Review comment:
I don't think it is necessary to remove the default implementation.
Overriding it in `StreamingDelete` should work just fine without causing a
binary compatibility change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
