rdblue commented on issue #474: Fix typo in the message for refreshing table metadata URL: https://github.com/apache/incubator-iceberg/pull/474#issuecomment-533624426 > If newLocation is the source location where the metadata is being refreshed from, could you please share your idea about what currentMetadataLocation stands for? `TableOperations` keeps track of the location that metadata was last read from. When refreshing, the location from the metastore is passed to `refreshFromMetadataLocation`, which may be the same as the currently loaded one that was used, or it may be new and should replace the currently loaded one. > Does the message of "Refreshing table metadata from new version: newLocation" indicate that meta data is being refreshed from newLocation, not that the mata data is being refreshed from currentMetadataLocation to newLocation ? It indicates that `newLocation` is not the currently loaded location, so the metadata will be refreshed from the new location. I think the confusion is because there are two "current" states. The `TableOperations` instance has a current state that is only updated when `refresh` is called. And the table itself has a current state in the metastore. The `refreshFromMetadataLocation` method is updating the current state of `TableOperations` from the current state fetched from the metastore, the `newLocation`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
