rdblue commented on a change in pull request #487: Add TIME_MICROS support to
GenericParquetReaders
URL: https://github.com/apache/incubator-iceberg/pull/487#discussion_r326836911
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
##########
@@ -366,6 +365,15 @@ public OffsetDateTime read(OffsetDateTime reuse) {
}
}
+ private static class TimeReader extends PrimitiveReader<LocalTime> {
+ private TimeReader(ColumnDescriptor desc) {
+ super(desc);
+ }
+
+ @Override
+ public LocalTime read(LocalTime reuse) { return
LocalTime.MIN.plus(column.nextLong(), ChronoUnit.MICROS); }
Review comment:
I think that test will work. Originally, I thought that it wasn't actually
testing the conversion, only that writing a time and reading it back produced
the same value. But that's okay because we are at least validating that the
read path does the opposite of the write path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
