rdblue commented on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-534223432 > I think you are referring to do something similar to my first approach where I was passing a map to PruneColumns to build an intermediate file avro schema, to be passed to BuildAvroProjection Yes! Sorry about that, I was wrong before. I thought that `buildAvroProjection` operated on two Iceberg schemas, so all you'd need to do is to add IDs when converting to Iceberg. But that's not correct: the primary schema is an Avro schema. (Unlike Parquet, where I think both are Iceberg and we fetch the aliases from the converted schema by ID.) I think the snippet you posted would make this change cleaner. Sorry to cause you more work with my mistake!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
