rdblue commented on issue #496: Adding back public access to Builder add method URL: https://github.com/apache/incubator-iceberg/pull/496#issuecomment-535273873 Thanks, @rominparekh. There was more discussion on #495 where @prodeezy gave the same example. I think the right way to make that use case work is to add methods to override the partition field name. Using add allows you to specify the name of the transform, but we don't really want people doing that because it is hard to register transforms. So instead, let's add something like this: ```java PartitionSpec.builderFor(schema) .day("timestamp", "c_date") .build() ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
