xabriel commented on a change in pull request #498: Adding partition transform
builder methods to set custom target field names
URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328702507
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -357,76 +357,100 @@ public Builder withSpecId(int newSpecId) {
return sourceColumn;
}
- public Builder identity(String sourceName) {
- checkAndAddPartitionName(sourceName);
+
+ public Builder identity(String sourceName, String targetName) {
+ checkAndAddPartitionName(targetName);
Review comment:
When the transform is not `identity`, should we add a check on
`checkAndAddPartitionName()` to see if the `targetName` is already a field name
in the `schema`? To me, it would be confusing to have a partition name and a
schema field be the same when they don't correlate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
