rdblue commented on a change in pull request #498: Adding partition transform
builder methods to set custom target field names
URL: https://github.com/apache/incubator-iceberg/pull/498#discussion_r328717472
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -357,76 +357,100 @@ public Builder withSpecId(int newSpecId) {
return sourceColumn;
}
- public Builder identity(String sourceName) {
- checkAndAddPartitionName(sourceName);
+
+ public Builder identity(String sourceName, String targetName) {
+ checkAndAddPartitionName(targetName);
Review comment:
I think this is a good point. We should not allow a partition field to have
the same name as a schema column unless the transform is identity.
Similarly, should we allow overriding the partition name when the transform
is identity? I think we should require them to use the same name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
