aokolnychyi commented on a change in pull request #497: Support retaining last
N snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r328991669
##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -310,6 +323,19 @@ private void deleteDataFiles(Set<String> manifestsToScan,
Set<String> manifestsT
return filesToDelete;
}
+ private Snapshot findNthSnapshot(int snapshotIndex) {
+ Snapshot lastSnapshot = base.currentSnapshot();
+ int snapshotCount = 1;
+ while (lastSnapshot != null) {
+ if (snapshotCount == snapshotIndex) {
+ return lastSnapshot;
+ }
+ snapshotCount++;
+ lastSnapshot = (lastSnapshot.parentId() != null) ?
base.snapshot(lastSnapshot.parentId()) : null;
Review comment:
@yathindranath can you elaborate on how that will look like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
