yathindranath commented on a change in pull request #497: Support retaining
last N snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r329194963
##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -310,6 +323,19 @@ private void deleteDataFiles(Set<String> manifestsToScan,
Set<String> manifestsT
return filesToDelete;
}
+ private Snapshot findNthSnapshot(int snapshotIndex) {
+ Snapshot lastSnapshot = base.currentSnapshot();
+ int snapshotCount = 1;
+ while (lastSnapshot != null) {
+ if (snapshotCount == snapshotIndex) {
+ return lastSnapshot;
+ }
+ snapshotCount++;
+ lastSnapshot = (lastSnapshot.parentId() != null) ?
base.snapshot(lastSnapshot.parentId()) : null;
Review comment:
1. Add this method to `ExpireSnapshots`
` @Override
public ExpireSnapshots expireDeleted() {
this.expireDeleted = true;
return this;
}`
2. Add `RemoveSnapshots.internalApply` will change as below
`return base.removeSnapshotsIf(snapshot ->
idsToRemove.contains(snapshot.snapshotId()) ||
(expireOlderThan != null && snapshot.timestampMillis() <
expireOlderThan)) ||
(expireDeleted && DataOperations.DELETE.equals(snapshot.operation));`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
