rdblue commented on a change in pull request #503: Fix snapshot summary data
for appended manifests.
URL: https://github.com/apache/incubator-iceberg/pull/503#discussion_r329328080
##########
File path: core/src/main/java/org/apache/iceberg/SnapshotProducer.java
##########
@@ -366,16 +366,18 @@ private static void
updateTotal(ImmutableMap.Builder<String, String> summaryBuil
long newTotal = Long.parseLong(totalStr);
String addedStr = currentSummary.get(addedProperty);
- if (addedStr != null) {
+ if (newTotal > 0 && addedStr != null) {
newTotal += Long.parseLong(addedStr);
}
String deletedStr = currentSummary.get(deletedProperty);
- if (deletedStr != null) {
+ if (newTotal > 0 && deletedStr != null) {
Review comment:
Fixed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
