rdblue commented on issue #505: [Bug] Timestamp based day transformed 
partitions fails on read
URL: 
https://github.com/apache/incubator-iceberg/issues/505#issuecomment-536635882
 
 
   Doesn't PR #506 fix #428? That's basically what it does.
   
   I'm fine adding that commit if it unblocks you, but this type of bug is 
going to keep happening to you if you continue to use this pattern where you 
write files and then use paths to build partition data when appending to a 
table. The `withPartitionPath` method is only intended for use with Hive 
partitions, and even then it is a best effort. Iceberg doesn't guarantee that 
partition strings even can be parsed to produce the original value because that 
has been an error prone anti-pattern in Hive.
   
   This is going to cause further problems with strings that require escaping, 
hourly partitions, etc. I suggest moving off of this pattern and keeping the 
partition tuples as data instead of recovering partition tuple values like this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to