rdblue commented on a change in pull request #512: Extend RewriteManifests with
a way to add/delete manifests
URL: https://github.com/apache/incubator-iceberg/pull/512#discussion_r331671734
##########
File path: api/src/main/java/org/apache/iceberg/RewriteManifests.java
##########
@@ -49,9 +51,35 @@
* that do not match the predicate are kept as-is. If this is not called and
no predicate is set, then
* all manifests will be rewritten.
*
+ * Note that either clusterBy/rewriteIf should be used or
deleteManifest/addManifest, not both.
+ *
* @param predicate Predicate used to determine which manifests to rewrite.
If true then the manifest
* file will be included for rewrite. If false then then
manifest is kept as-is.
* @return this for method chaining
*/
RewriteManifests rewriteIf(Predicate<ManifestFile> predicate);
+
+ /**
+ * Deletes a {@link ManifestFile manifest file} from the table. This method
should be used
+ * together with {@link #addManifest(ManifestFile)} when manifests are
rewritten using
+ * an external process.
Review comment:
This should also note that manifest rewrites must produce the same set of
data files between the deleted manifests and the added manifests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
