rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333140039
##########
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
##########
@@ -196,15 +199,38 @@ static Schema createProjectionMap(String recordName,
return LogicalMap.get().addToSchema(Schema.createArray(keyValueRecord));
}
- private static int getId(Schema schema, String propertyName) {
+
+ static Integer getId(Schema schema, String propertyName) {
Review comment:
I don't think there is a reason to remove the private modifier. It is still
only used by other methods in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
