rdsr commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r333145829
########## File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java ########## @@ -58,10 +76,9 @@ public Schema record(Schema record, List<String> names, List<Schema> fields) { // case where the converted field is non-null is when a map or list is // selected by lower IDs. if (selectedIds.contains(fieldId)) { - filteredFields.add(copyField(field, field.schema())); + filteredFields.add(copyField(field, field.schema(), fieldId)); } else if (fieldSchema != null) { - hasChange = true; - filteredFields.add(copyField(field, fieldSchema)); + filteredFields.add(copyField(field, fieldSchema, fieldId)); Review comment: You are right! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org