rdblue commented on a change in pull request #526: Add Baseline to
iceberg-parquet
URL: https://github.com/apache/incubator-iceberg/pull/526#discussion_r334289245
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -98,18 +98,18 @@ public WriteBuilder forTable(Table table) {
return this;
}
- public WriteBuilder schema(Schema schema) {
- this.schema = schema;
+ public WriteBuilder schema(Schema setSchema) {
+ this.schema = setSchema;
Review comment:
The convention used elsewhere to get around this problem is to use "new" as
in `newSchema`. Could you use that instead for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
