rdsr commented on a change in pull request #525: Apply Baseline to iceberg-pig
URL: https://github.com/apache/incubator-iceberg/pull/525#discussion_r334289841
 
 

 ##########
 File path: pig/src/main/java/org/apache/iceberg/pig/IcebergStorage.java
 ##########
 @@ -290,8 +265,8 @@ public RequiredFieldResponse 
pushProjection(RequiredFieldList requiredFieldList)
   }
 
   @Override
-  public void setUDFContextSignature(String signature) {
-    this.signature = signature;
+  public void setUDFContextSignature(String setSignature) {
 
 Review comment:
   nit: instead of set or init, we've used new in other modules 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to