manishmalhotrawork commented on a change in pull request #499: Add persistent
IDs to partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r336631328
##########
File path: core/src/main/java/org/apache/iceberg/SchemaUpdate.java
##########
@@ -206,7 +208,7 @@ public Schema apply() {
@Override
public void commit() {
- TableMetadata update = applyChangesToMapping(base.updateSchema(apply(),
lastColumnId));
+ TableMetadata update = applyChangesToMapping(base.updateSchema(apply(),
lastColumnId, lastPartitionFieldId));
Review comment:
yeah, its not required.
As its a schema update, and ideally we dont need keep lastPartitionFieldId
at the schemaUpdate level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
