manishmalhotrawork edited a comment on issue #499: Add persistent IDs to 
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#issuecomment-544110714
 
 
   @rdblue please see, updated PR to reusing field-id .
   one downside I see is, have to iterate the PartitionSpec two times, 
otherwise have to initialize two maps from same method.
   `TableMetadata.indexSpecs` and 
`TableMetadata.indexPartitionFieldIdByColumnName` are the ones. Though this 
will happen, only at the time of creating a new TableMetadata.
   Please share your thoughts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to