rdblue commented on a change in pull request #624: Update SparkTableUtil to use 
SessionCatalog and proper MetricsConfig
URL: https://github.com/apache/incubator-iceberg/pull/624#discussion_r344411488
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/MetricsModes.java
 ##########
 @@ -144,4 +146,22 @@ public String toString() {
       return "full";
     }
   }
+
+  private abstract static class ProxySerializableMetricsMode implements 
MetricsMode {
 
 Review comment:
   Can you add this as a comment in the code so we don't forget this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to