aokolnychyi commented on a change in pull request #624: Update SparkTableUtil
to use SessionCatalog and proper MetricsConfig
URL: https://github.com/apache/incubator-iceberg/pull/624#discussion_r344658581
##########
File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala
##########
@@ -259,7 +326,7 @@ object SparkTableUtil {
partitionPath: Map[String, String],
partitionUri: String,
conf: Configuration,
- metricsSpec: MetricsConfig = MetricsConfig.getDefault):
Seq[SparkDataFile] = {
+ metricsSpec: MetricsConfig): Seq[SparkDataFile] = {
Review comment:
It is a private method and I think it is better to explicitly require a
metrics config to be sure the caller really wants to pass
`MetricsConfig.getDefault`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
