rdblue commented on a change in pull request #588: Add sequential number
prepare for supporting row level delete (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r344927539
##########
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##########
@@ -128,7 +130,7 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
}
}
- private ManifestFile writeManifest() throws IOException {
+ private ManifestFile writeManifest(long availSeqNum) throws IOException {
Review comment:
Sequence numbers are not written into manifests during commit because the
order of commits is not known until the commit succeeds. Retries require
changing the sequence number.
To get around this, sequence numbers are written into the manifest list for
each ManifestFile object, and are inherited when reading a manifest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
