rdblue commented on issue #627: Update indexing to handle nested lists
URL: https://github.com/apache/incubator-iceberg/pull/627#issuecomment-553190551
 
 
   @chenjunjiedada, the problem in that commit was that not all of the visitor 
methods return a non-null map, so calling `size` on child results could fail. 
All we need to do is to iterate through the list to index the children, which 
is why we now use `Lists.newArrayList`. Since we also have to do something to 
consume the output, we call `size` on that list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to