rdblue commented on a change in pull request #631: Add mechanism to expire old
metadata versions
URL: https://github.com/apache/incubator-iceberg/pull/631#discussion_r346018469
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -272,4 +273,194 @@ public static String toJsonWithoutSpecList(TableMetadata
metadata) {
}
return writer.toString();
}
+
+ @Test
+ public void testJsonWithPreviousMetadataLog() throws Exception {
Review comment:
This should also check that metadata files without the new content can still
be loaded without causing an error. You can use `toJsonWithoutSpecList` or
similar methods to generate the older content, then add assertions that
validate the parser produces the default value you expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
