rdblue commented on issue #631: Add mechanism to expire old metadata versions URL: https://github.com/apache/incubator-iceberg/pull/631#issuecomment-554168010 @aokolnychyi, I think if we add expiration during ExpireSnapshots, then that's when the number of metadata versions would be pruned. For example, expiration might keep 10 previous metadata file references. Between expiration calls, the ones tracked continues to grow. If that's the case, then to keep metadata from getting too large, we would drop at some maximum number of versions at commit time, and delete the file if that property is set. So the cleanup implemented here is a failsafe and the preferred way to expire is through snapshot expiration. Then 100 maximum old versions makes sense, and expiration might bring it down to 10 or 3 or something.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
