yathindranath commented on a change in pull request #631: Add mechanism to
expire old metadata versions
URL: https://github.com/apache/incubator-iceberg/pull/631#discussion_r346985213
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -268,20 +325,24 @@ public Snapshot currentSnapshot() {
return snapshotLog;
}
+ public List<MetadataLogEntry> previousMetadata() {
Review comment:
@aokolnychyi Not sure if I got it correctly.
The `previousMetadata` is very similar to `snapshotLog`, I think returning
List<MetadataLogEntry> make sense to me. I'm fine with any name.
The initial implementation of `addPreviousMetadata` was to return another
instance of `TableMetadata`, but moving the logic of handling previous versions
to `TableMetadata` is better I believe.
The `deleteRemovedMetadata` is not changing the state of `TableMetadata`,
it's better not to return another instance of `TableMetadata`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
