rdblue commented on a change in pull request #619: Add schema validator
URL: https://github.com/apache/incubator-iceberg/pull/619#discussion_r347107154
##########
File path: data/src/test/java/org/apache/iceberg/data/DataTest.java
##########
@@ -160,6 +169,8 @@ public void testMixedTypes() throws IOException {
)))
);
+ Schema schema = new Schema(TypeUtil.assignFreshIds(structType,
this::assignNewId).asStructType().fields());
Review comment:
You should be able to use `(new AtomicInteger(0))::incrementAndGet` instead.
There is no need to create global state in the test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
