lxynov commented on a change in pull request #591: Decouple TableMetadataParser
and TableMetadata from TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/591#discussion_r347562514
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -160,7 +166,7 @@ private void cacheChanges() {
// read only manifests that were created by this snapshot
Iterable<ManifestFile> changedManifests = Iterables.filter(manifests(),
manifest -> Objects.equal(manifest.snapshotId(), snapshotId));
- try (CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops,
changedManifests)
+ try (CloseableIterable<ManifestEntry> entries = new ManifestGroup(io,
changedManifests, specsById)
Review comment:
Did you mean to pass one entry (a partition spec) instead the map?
(Sorry for the late response)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
