xabriel commented on a change in pull request #656: Fix case sensitivity
setting in Spark
URL: https://github.com/apache/incubator-iceberg/pull/656#discussion_r347723849
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -71,9 +71,9 @@ public DataSourceReader createReader(DataSourceOptions
options) {
public DataSourceReader createReader(StructType readSchema,
DataSourceOptions options) {
Configuration conf = new Configuration(lazyBaseConf());
Table table = getTableAndResolveHadoopConfiguration(options, conf);
- String caseSensitive =
lazySparkSession().conf().get("spark.sql.caseSensitive", "true");
+ String caseSensitive =
lazySparkSession().conf().get("spark.sql.caseSensitive");
Review comment:
Just to confirm there is a default and so there is no chance of failing with
a not found exception:
https://github.com/apache/spark/blob/7955b3962ac46b89564e0613db7bea98a1478bf2/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L279-L284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
