aokolnychyi commented on a change in pull request #652: Fix UUID check for 
existing tables without a UUID
URL: https://github.com/apache/incubator-iceberg/pull/652#discussion_r348005717
 
 

 ##########
 File path: 
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
 ##########
 @@ -149,8 +149,8 @@ protected void refreshFromMetadataLocation(String 
newLocation, Predicate<Excepti
               TableMetadataParser.read(this, 
io().newInputFile(metadataLocation))));
 
       String newUUID = newMetadata.get().uuid();
-      if (currentMetadata != null) {
-        Preconditions.checkState(newUUID == null || 
newUUID.equals(currentMetadata.uuid()),
+      if (currentMetadata != null && currentMetadata.uuid() != null && newUUID 
!= null) {
 
 Review comment:
   Do we have to update `HadoopTableOperations` as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to