rdblue commented on a change in pull request #657: Add list tables support in
Iceberg catalog
URL: https://github.com/apache/incubator-iceberg/pull/657#discussion_r348078483
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
##########
@@ -26,12 +26,22 @@
import org.apache.iceberg.Transaction;
import org.apache.iceberg.exceptions.AlreadyExistsException;
import org.apache.iceberg.exceptions.NoSuchTableException;
+import org.apache.iceberg.exceptions.NotFoundException;
/**
* A Catalog API for table create, drop, and load operations.
*/
public interface Catalog {
+ /**
+ * Return all the identifiers under this namespace.
Review comment:
Sounds like this is doing the right thing already and ignoring views. It
would be good to have the Javadoc state that's what this will do. Looks like
the return docs already do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
