rdblue commented on a change in pull request #315: [WIP] Incremental processing
prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r348146477
##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -44,6 +44,15 @@
*/
TableScan newScan();
+
+ /**
+ * @param fromSnapshotId - the last snapshot id read by the user, exclusive
+ * @param toSnapshotId - read incremental data upto this snapshot id
+ * @return a table scan which can read incremental data from {@param
fromSnapshotId}
+ * exclusive and up to {@toSnapshotId} inclusive
+ */
+ TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId);
Review comment:
That sounds reasonable to me, but I think it should also be possible to
start consuming from a specific snapshot, since processing the rest of the
table seems needlessly expensive in a lot of cases. We move jobs from batch to
streaming and don't want to rewrite the history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
