rdblue commented on a change in pull request #665: PR#1 for merging
vectorized-read branch into master
URL: https://github.com/apache/incubator-iceberg/pull/665#discussion_r349273245
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetUtil.java
##########
@@ -127,18 +138,16 @@ public static Metrics footerMetrics(ParquetMetadata
metadata, MetricsConfig metr
toBufferMap(fileSchema, lowerBounds), toBufferMap(fileSchema,
upperBounds));
}
-
/**
- * @return a list of offsets in ascending order determined by the starting
position
- * of the row groups
+ * @return a list of offsets in ascending order determined by the starting
position of the row groups
*/
public static List<Long> getSplitOffsets(ParquetMetadata md) {
List<Long> splitOffsets = new ArrayList<>(md.getBlocks().size());
for (BlockMetaData blockMetaData : md.getBlocks()) {
splitOffsets.add(blockMetaData.getStartingPos());
}
Collections.sort(splitOffsets);
- return splitOffsets;
+ return ImmutableList.copyOf(splitOffsets);
Review comment:
Same here, I don't think we need this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
