jerryshao commented on a change in pull request #674: [WIP]Supports spark-3.0
data source V2 APIs
URL: https://github.com/apache/incubator-iceberg/pull/674#discussion_r353593239
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/IcebergBatchScan.java
##########
@@ -115,61 +116,83 @@
private StructType type = null; // cached because Spark accesses it multiple
times
private List<CombinedScanTask> tasks = null; // lazy cache of tasks
- Reader(Table table, boolean caseSensitive, DataSourceOptions options) {
+ public IcebergBatchScan(Table table, Boolean caseSensitive,
CaseInsensitiveStringMap options) {
Review comment:
Also here, why the constructor changes to `public`? Besides, `Boolean`
should be changed to primitive type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
