prodeezy commented on a change in pull request #497: Support retaining last N
snapshots
URL: https://github.com/apache/incubator-iceberg/pull/497#discussion_r353961853
##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -55,6 +55,15 @@
*/
ExpireSnapshots expireOlderThan(long timestampMillis);
+ /**
+ * Retains at least last N snapshots and expires all snapshots older than
the given timestamp
Review comment:
this comment is not in sync with the api. `Expires older than given
timestamp` aught to be `Expires all snapshots older than the n snapshots from
current_snapshot`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
