rdblue commented on a change in pull request #686: Add transform expressions
URL: https://github.com/apache/incubator-iceberg/pull/686#discussion_r355151458
##########
File path: api/src/main/java/org/apache/iceberg/expressions/BoundPredicate.java
##########
@@ -20,18 +20,35 @@
package org.apache.iceberg.expressions;
import org.apache.iceberg.StructLike;
+import org.apache.iceberg.types.Type;
+import org.apache.iceberg.types.Types;
-public abstract class BoundPredicate<T> extends Predicate<BoundReference<T>> {
- protected BoundPredicate(Operation op, BoundReference<T> ref) {
- super(op, ref);
+public abstract class BoundPredicate<T> extends Predicate<T, Bound<T>>
implements Bound<Boolean> {
Review comment:
Okay, I cleaned this up quite a bit. I renamed `ValueExpression` to `Term`.
That makes more sense because these are really one operand in a predicate, not
a different kind of expression.
I also updated `Bound` and `Unbound` so they are independent, but I had to
add `UnboundTerm` and `BoundTerm`. Overall, I think that's fine.
The structure is quite a bit cleaner now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
