mccheah commented on a change in pull request #694: Add Spark Avro JMH tests
URL: https://github.com/apache/incubator-iceberg/pull/694#discussion_r355402440
##########
File path: build.gradle
##########
@@ -251,6 +251,14 @@ project(':iceberg-spark') {
}
testCompile project(path: ':iceberg-hive', configuration: 'testArtifacts')
testCompile project(path: ':iceberg-api', configuration: 'testArtifacts')
+
+ // spark-avro is required only for JMH tests, so ideally we would add this
+ // dependency only to the jmh configuration, however
gradle-consistent-versions
+ // plugin does not respect this configuration and does not seem to have a
way
+ // to add custom configurations in its lockable configuration detection
+ compileOnly("org.apache.spark:spark-avro_2.11") {
Review comment:
Actually since we do `compileOnly` for `spark-hive` above this is ok from
precedent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
