rdsr commented on a change in pull request #315: [WIP] Incremental processing
prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r356328746
##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -44,6 +44,15 @@
*/
TableScan newScan();
+
+ /**
+ * @param fromSnapshotId - the last snapshot id read by the user, exclusive
+ * @param toSnapshotId - read incremental data upto this snapshot id
+ * @return a table scan which can read incremental data from {@param
fromSnapshotId}
+ * exclusive and up to {@toSnapshotId} inclusive
+ */
+ TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId);
Review comment:
When using incremental for the first time [bootstrap] I think
`fromSnapshotId` should be null since the contract is an incremental scan
gives all the appends between `fromSnapshotId` **exclusive** to `toSnapshotId`
. When `fromSnapshotId` is null we will return all the appends till
`toSnapshotId`. In this way a user will not miss any data.
thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
