rdblue commented on a change in pull request #696: [spark-3]Fix build issue and
one import issue
URL: https://github.com/apache/incubator-iceberg/pull/696#discussion_r356751968
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -63,8 +63,8 @@ private SparkFilters() {
private static final ImmutableMap<Class<? extends Filter>, Operation>
FILTERS = ImmutableMap
.<Class<? extends Filter>, Operation>builder()
- .put(AlwaysTrue$.class, Operation.TRUE)
- .put(AlwaysFalse$.class, Operation.FALSE)
+ .put(AlwaysTrue.class, Operation.TRUE)
+ .put(AlwaysFalse.class, Operation.FALSE)
Review comment:
`AlwaysTrue$` is the class of the Scala object `AlwaysTrue` and is a
subclass of `AlwaysTrue`. Instead of removing it, let's add both classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
