Fokko commented on a change in pull request #297: Bump Apache Avro to 1.9.x
URL: https://github.com/apache/incubator-iceberg/pull/297#discussion_r356828570
 
 

 ##########
 File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestDataSourceOptions.java
 ##########
 @@ -196,6 +196,6 @@ public void testSplitOptionsOverridesTableProperties() 
throws IOException {
         .option("split-size", String.valueOf(562L)) // 562 bytes is the size 
of SimpleRecord(1,"a")
         .load(tableLocation);
 
-    Assert.assertEquals("Spark partitions should match", 2, 
resultDf.javaRDD().getNumPartitions());
+    Assert.assertEquals("Spark partitions should match", 4, 
resultDf.javaRDD().getNumPartitions());
 
 Review comment:
   I've written a single record, and updated the size to 611:
   ```
   $ ls -la 
/var/folders/km/xypq2kxs4ys3dt6bwtd4fbj00000gn/T/junit8105143976887819489/iceberg-table/data/
   total 16
   drwxr-xr-x  4 fokkodriesprong  staff  128 11 dec 21:51 .
   drwxr-xr-x  4 fokkodriesprong  staff  128 11 dec 21:51 ..
   -rw-r--r--  1 fokkodriesprong  staff   16 11 dec 21:51 
.00000-0-44b7bf06-961b-4f36-9350-8711db220a8e-00000.parquet.crc
   -rw-r--r--  1 fokkodriesprong  staff  611 11 dec 21:51 
00000-0-44b7bf06-961b-4f36-9350-8711db220a8e-00000.parquet
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to