danielcweeks commented on a change in pull request #686: Add transform
expressions
URL: https://github.com/apache/incubator-iceberg/pull/686#discussion_r357277758
##########
File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
##########
@@ -19,21 +19,24 @@
package org.apache.iceberg.expressions;
-public abstract class Predicate<R extends Reference> implements Expression {
+import com.google.common.base.Preconditions;
+
+public abstract class Predicate<T, C extends Term> implements Expression {
private final Operation op;
- private final R ref;
+ private final C child;
- Predicate(Operation op, R ref) {
+ Predicate(Operation op, C child) {
+ Preconditions.checkNotNull(child, "Term cannot be null");
this.op = op;
- this.ref = ref;
+ this.child = child;
}
@Override
public Operation op() {
return op;
}
- public R ref() {
- return ref;
+ public C child() {
Review comment:
This may be somewhat pedantic, but the name `child` doesn't seem right here.
I would suggest ~~`comparand`~~ (`term` might be better).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
