manishmalhotrawork commented on a change in pull request #666:
BaseRewriteManifests should keep different manifest for different partitionSpec
URL: https://github.com/apache/incubator-iceberg/pull/666#discussion_r357800060
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -312,33 +311,58 @@ long getManifestTargetSizeBytes() {
}
class WriterWrapper {
- private ManifestWriter writer;
-
- synchronized void addEntry(ManifestEntry entry) {
- if (writer == null) {
- writer = newWriter();
- } else if (writer.length() >= getManifestTargetSizeBytes()) {
- close();
- writer = newWriter();
+ private final Map<Integer, ManifestWriter> manifestWritersBySpecId =
Collections.synchronizedMap(new HashMap<>());
+
+ synchronized void addEntry(ManifestEntry entry, int partitionSpecId) {
+ ManifestWriter manifestWriter =
manifestWritersBySpecId.get(partitionSpecId);
+ if (manifestWriter == null) {
+ manifestWriter = addAndReturnNewWriter(partitionSpecId);
+ } else if (manifestWriter.length() >= getManifestTargetSizeBytes()) {
+ close(partitionSpecId);
+ manifestWriter = addAndReturnNewWriter(partitionSpecId);
}
- writer.existing(entry);
+ manifestWriter.existing(entry);
}
- private ManifestWriter newWriter() {
- return new ManifestWriter(spec,
manifestPath(manifestSuffix.getAndIncrement()), snapshotId());
+ private ManifestWriter addAndReturnNewWriter(int partitionSpecId) {
Review comment:
>I know that it is OK to use newWriter right now but we rely on the correct
logic in other methods. That's, probably, fine but it felt safer to have this
check to be sure we don't replace a writer that hasn't been closed yet (if
something changes later on in the code).
Also, I think it would be slightly more readable to have args to
ManifestWriter as separate variables like in the snippet above.
make sense. let me take care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
