rdblue commented on a change in pull request #695: [WIP] Cherrypick snapshot 
feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r358398294
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/Table.java
 ##########
 @@ -206,6 +206,12 @@ default AppendFiles newFastAppend() {
    */
   Rollback rollback();
 
 Review comment:
   Can we combine this with the Rollback API? We could still support the 
`rollback` method here, but combine `Rollback` and `CherryPick` into something 
like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the 
current snapshot. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to