rdblue commented on a change in pull request #706: Add DeleteFrom support for 
Spark 3.0
URL: https://github.com/apache/incubator-iceberg/pull/706#discussion_r360471577
 
 

 ##########
 File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
 ##########
 @@ -119,4 +124,16 @@ public WriteBuilder 
newWriteBuilder(CaseInsensitiveStringMap options) {
     return new SparkWriteBuilder(sparkSession(), icebergTable, options);
   }
 
+  @Override
+  public void deleteWhere(Filter[] filters) {
+    icebergTable.newDelete()
+        .set("spark.app.id", sparkSession().sparkContext().applicationId())
+        .deleteFromRowFilter(SparkFilters.convert(filters))
 
 Review comment:
   The error message is fairly clear. It says that there was a file that may 
contain both records that should be deleted and records that should not be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to