rdblue commented on a change in pull request #688: [ISSUE #672] Add
SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r360478728
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java
##########
@@ -53,7 +53,7 @@ public void deleteFile(String path) {
try {
fs.delete(toDelete, false /* not recursive */);
} catch (IOException e) {
- throw new RuntimeIOException(e, "Failed to delete file: %s", path);
+ throw new RuntimeIOException("Cannot delete the file: %s", path,
e.getMessage());
Review comment:
Please revert this change.
Caught exceptions should almost always be added to the exception thrown, and
the error message was fine.
This also breaks formatting because there are two arguments but only one
`%s` in the format string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
