rdblue commented on a change in pull request #688: [ISSUE #672] Add
SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r360950529
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -57,10 +63,14 @@
*
* Note: The HadoopCatalog requires that the underlying file system supports
atomic rename.
*/
-public class HadoopCatalog extends BaseMetastoreCatalog implements Closeable {
+public class HadoopCatalog extends BaseMetastoreCatalog implements Closeable,
SupportsNamespaces {
private static final String ICEBERG_HADOOP_WAREHOUSE_BASE =
"iceberg/warehouse";
+ private static final String TABLE_METADATA_FILE_EXTENSION = ".metadata.json";
+ private static final PathFilter TABLE_FILTER = path ->
path.getName().endsWith(TABLE_METADATA_FILE_EXTENSION);
private final Configuration conf;
private String warehouseLocation;
+ private HadoopFileIO defaultFileIo = null;
+ private static final Joiner SLASH = Joiner.on("/");
Review comment:
Static final variables should be grouped together at the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
