rdblue commented on a change in pull request #710: Parquet changes for 
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/710#discussion_r361017406
 
 

 ##########
 File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
 ##########
 @@ -362,6 +367,16 @@ public ReadBuilder createReaderFunc(Function<MessageType, 
ParquetValueReader<?>>
       return this;
     }
 
+    public ReadBuilder createBatchedReaderFunc(Function<MessageType, 
VectorizedReader<?>> func) {
+      this.batchedReaderFunc = func;
+      return this;
+    }
+
+    public ReadBuilder enableBatchedRead() {
 
 Review comment:
   Why not enable batch read when `createBatchReaderFunc` is called? If that's 
null, then use the other read path. If it is defined, then use the vectorized 
path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to