rdblue commented on a change in pull request #710: Parquet changes for
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/710#discussion_r361723981
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java
##########
@@ -41,11 +41,11 @@
/**
* Methods in this class translate from the IO API to Parquet's IO API.
*/
-class ParquetIO {
+public class ParquetIO {
Review comment:
Why do these methods need to be public? These should only be used to convert
Iceberg's `InputFile` and `OutputFile` interfaces to versions that can be used
with Parquet. Iceberg should keep these internal because all the external APIs
should use Iceberg's interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
