rdblue commented on a change in pull request #688: [ISSUE #672] Add
SupportsNamespaces for 'HadoopCatalog' and 'HiveCatalog'
URL: https://github.com/apache/incubator-iceberg/pull/688#discussion_r362057867
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -108,7 +119,7 @@ protected String name() {
try {
if (!fs.exists(nsPath) || !fs.isDirectory(nsPath)) {
- throw new NotFoundException("Unknown namespace " + namespace);
+ throw new NoSuchNamespaceException("Namespace does not exist: " +
namespace);
Review comment:
This exception class supports format strings and args, so this should use
`%s` and pass namespace as an argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
