aokolnychyi commented on issue #675: Inherit snapshot ids for manifest entries URL: https://github.com/apache/incubator-iceberg/pull/675#issuecomment-572609803 I run a few basic benchmarks locally (e.g. add/read 100 manifests that are 275KB in size and contain 10000 entries). With this PR: ``` Benchmark Mode Cnt Score Error Units AppendManifestsBenchmark.fastAppendManifests ss 5 2.468 ± 0.087 s/op AppendManifestsBenchmark.mergeAppendManifests ss 5 4.489 ± 0.103 s/op ReadManifestsBenchmark.basicPlanFiles ss 5 0.489 ± 0.103 s/op ``` Before this PR: ``` Benchmark Mode Cnt Score Error Units AppendManifestsBenchmark.fastAppendManifests ss 5 6.387 ± 1.068 s/op AppendManifestsBenchmark.mergeAppendManifests ss 5 8.007 ± 0.217 s/op ReadManifestsBenchmark.basicPlanFiles ss 5 0.496 ± 0.051 s/op ``` Right now, we still read manifests to get stats. I think we can address that in a follow-up PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
